fix: ics compat with older ical specced calendars #19582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrysal
changed the title
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (02/26/25)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
E2E results are ready! |
zomars
reviewed
Feb 26, 2025
| startInputType: "utc", | ||
| productId: "calcom/ics", | ||
| title: event.title, | ||
| description: getRichDescription(event, t), | ||
| duration: { minutes: dayjs(event.endTime).diff(dayjs(event.startTime), "minute") }, |
There was a problem hiding this comment.
Is duration isnt' needed anymore?
There was a problem hiding this comment.
No, dtend takes it's place, duration is newer spec that allows for dynamic duration which we don't need :)
emrysal
deleted the
bugfix/ics-compat-with-older-ical-specced-calendars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?