perf: Do not import Stripe lib in getServerErrorFromUnknown
#19578
+101
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hbjORbj
changed the title
hbjORbj
changed the title
getServerErrorFromUnknown
hbjORbj
commented
Feb 26, 2025
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/26/25)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
changed the title
getServerErrorFromUnknowngetServerErrorFromUnknown
E2E results are ready! |
zomars
requested changes
Feb 26, 2025
|
@zomars Let's copy and paste the relevant parts of the source code instead of relying on "any"s Addressed! |
dosubot
bot
added
the
performance
zomars
reviewed
Feb 26, 2025
|
Changes look good @hbjORbj. Before merging can we post evidence that a Stripe error is properly being caught and displayed? |
zomars
previously approved these changes
Feb 26, 2025
Gottcha |
|
@zomars Hey Zomar, I added a unit test. Can you reapprove after review? |
zomars
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
two reasons for this PR:
getServerErrorFromUnknown, importing stripe lib throws an error because it's incompatible with the Edge Runtime due to its reliance on Node.js-specific APIs like crypto and httpgetServerErrorFromUnknownMandatory Tasks (DO NOT REMOVE)
How should this be tested?