Using dev-master is always bad

[GrahamCampbell]

No description provided.

[jbrooksuk]

Thanks buddy.

[GrahamCampbell]

np. :) Sorry I couldn't update the lock file again. This was a quick pull from github's online interface.

[jbrooksuk]

Don't worry about it, I'm just about to push that.

[GrahamCampbell]

Also, your description in the composer.json is incorrect. It says that this is laravel. :)

[jbrooksuk]

Whoops! I'll change that now, good spot! :)

[GrahamCampbell]

It would be cool if you published this to packagist too, so people can use composer create-project to install cachet.

[jbrooksuk]

That's something I need to add to the roadmap actually.

I'm not sure if I should do that now or once v1 is released, what do you think?

[GrahamCampbell]

I would. It does no harm. I did with bootstrap cms over a year ago, and I still haven't tagged 1.0 yet.

[jbrooksuk]

Ok, awesome, I'll get on that.

[GrahamCampbell]

👍

[jbrooksuk]

Done.

[GrahamCampbell]

👍

[GrahamCampbell]

Also, just decided to run your repo through my cs checker: https://styleci.grahamjcampbell.co.uk/repos/a7d1a3cdabcbd06624dbc2db0aca3036d2947ad5.

https://styleci.grahamjcampbell.co.uk/commits/003801ba013632c9d4f92f2a07dbfff6aabcb17c/diff

[GrahamCampbell]

Interesting - your namespace violates psr-0/psr-4.

[GrahamCampbell]

CachetHQ should be CachetHq apparently?

[jbrooksuk]

Woah, cheers. That's interesting, I didn't know you couldn't have HQ.

I guess we could change it, but it does seem weird?

[GrahamCampbell]

Yeh, it is odd.

[GrahamCampbell]

#80

[GrahamCampbell]

I can disable psr0 fixer if required, because it is odd. Maybe just namespacing it under Cachet would be a good idea?

[jbrooksuk]

Thanks!

If we went with just Cachet it would be Cachet\Cachet and that feels odd to me. Especially since in the future we may develop custom packages under the CachetHQ org, I felt it should match the GitHub org too.

Is it PSR-0 that's causing the issue here?

[GrahamCampbell]

No - it because you named the folder wrong...

[GrahamCampbell]

It was adjusting the namespace because on case sensitivity matters on some systems for autoloading.

[jbrooksuk]

Oh because it's CachetHq but the org is CachetHQ?

[GrahamCampbell]

Yeh, the folder can't be named CachetHq when the namespace is CachetHQ. They must match.

[jbrooksuk]

That's easy to fix :)

[GrahamCampbell]

btw, I'm using /~https://github.com/FriendsOfPHP/PHP-CS-Fixer under the hood here.

The power to fix docblocks should be massively improving after PHP-CS-Fixer/PHP-CS-Fixer#887 goes through.

[jbrooksuk]

That's awesome!

Blows out the need for @anorakci ;)