Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with gradle 7.x #17

Closed
roee88 opened this issue Jun 14, 2021 · 7 comments
Closed

Doesn't work with gradle 7.x #17

roee88 opened this issue Jun 14, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@roee88
Copy link

roee88 commented Jun 14, 2021

getLibsDir was deprecated in 6.x and removed in 7.x

@saudet
Copy link
Member

saudet commented Jun 14, 2021

Do you know of an alternative way of doing this that would be compatible with Gradle 5.x?

@roee88
Copy link
Author

roee88 commented Jun 17, 2021

I think that getLibsDirName is available in both versions.

However, BasePluginConvention itself will be removed in the next gradle version and I'm not familiar enough with gradle's model for plugin development with respect to backward compatibility. My request would be to change the readme to state that gradle 5.x is required instead of "or newer", maybe even use the gradle w rapper and commit the files with 5.x.

@saudet
Copy link
Member

saudet commented Jun 17, 2021

I'm all for supporting Gradle 7.x and even 8.x when it comes out, but let's see if we can keep backward compatibility. Can you try to use getLibsDirName​() to see if it works for now?

@saudet saudet added enhancement New feature or request help wanted Extra attention is needed labels Jun 24, 2021
@saudet
Copy link
Member

saudet commented Jun 28, 2021

I think that getLibsDirName is available in both versions.

I've made the change in the latest commit and it now with Gralde 7.x.
Please give it a try with the snapshots: http://bytedeco.org/builds/

I'm still getting a few warnings for Gradle 8.0, and it looks like it will be hard to keep compatibility with 5.0, but we still have something like year before that happens, and by then we might as well just drop support for it.

However, BasePluginConvention itself will be removed in the next gradle version and I'm not familiar enough with gradle's model for plugin development with respect to backward compatibility. My request would be to change the readme to state that gradle 5.x is required instead of "or newer", maybe even use the gradle w rapper and commit the files with 5.x.

The Gradle Wrapper doesn't help for plugins. Those essentially become part of Gradle at runtime and are typically tied to a very narrow range of versions of Gradle.

In any case, thanks for reporting this issue and for your help solving it!

@saudet saudet removed the help wanted Extra attention is needed label Jun 28, 2021
@roee88
Copy link
Author

roee88 commented Jun 28, 2021

Thanks, I'll give it a try and update.

The Gradle Wrapper doesn't help for plugins. Those essentially become part of Gradle at runtime and are typically tied to a very narrow range of versions of Gradle.

I meant for the examples, sorry I wasn't clear.

@saudet
Copy link
Member

saudet commented Jun 29, 2021

Thanks, I'll give it a try and update.

👍

The Gradle Wrapper doesn't help for plugins. Those essentially become part of Gradle at runtime and are typically tied to a very narrow range of versions of Gradle.

I meant for the examples, sorry I wasn't clear.

Ah, the scripts for that are pretty large and I find it just creates noise in the repository here since the sample code is meant to be part of the "documentation". For complete sample projects like that, we can put those on /~https://github.com/bytedeco/sample-projects, even if it's essentially the same thing but with Gradle Wrapper.

@roee88
Copy link
Author

roee88 commented Jul 7, 2021

It works, many thanks

@roee88 roee88 closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants