Bump golang/mock to 1.5.0 #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix breaking tests Signed-off-by: Anthony Emengo <aemengo@vmware.com>
github-actions
bot
added
type/chore
aemengo
commented
Mar 3, 2021
Comment on lines
+101
to
+104
| go func(w *sync.WaitGroup, i int, builder SuggestedBuilder) { | ||
| descriptions[i] = getBuilderDescription(builder, inspector) | ||
| wg.Done() | ||
| }(i, builder) | ||
| w.Done() | ||
| }(&wg, i, builder) |
There was a problem hiding this comment.
#BuildCommand/no builder is specified/returns a soft error was hanging without this change.
Codecov Report
@@ Coverage Diff @@
## main #1097 +/- ##
=======================================
Coverage 80.41% 80.41%
=======================================
Files 133 133
Lines 8156 8156
=======================================
Hits 6558 6558
Misses 1170 1170
Partials 428 428
Flags with carried forward coverage won't be shown. Click here to find out more. |
jromero
removed
the
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump gomock testing library. And fixed the tests that were breaking.
Resolves #1087