Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heroku/buildpacks:20 to suggested builders list #1052

Merged

Conversation

jabrown85
Copy link
Contributor

Summary

heroku-20 is the default stack on Heroku now, adding the builder for this stack at this time seems reasonable.

Signed-off-by: Jesse Brown jabrown85@gmail.com

Output

Before

» out/pack config trusted-builders list
Trusted Builders:
  gcr.io/buildpacks/builder:v1
  heroku/buildpacks:18
  paketobuildpacks/builder:base
  paketobuildpacks/builder:full
  paketobuildpacks/builder:tiny

After

» out/pack config trusted-builders list
Trusted Builders:
  gcr.io/buildpacks/builder:v1
  heroku/buildpacks:18
  heroku/buildpacks:20
  paketobuildpacks/builder:base
  paketobuildpacks/builder:full
  paketobuildpacks/builder:tiny

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

`heroku-20` is the default stack on Heroku now, adding the builder for this stack at this time seems reasonable.

Signed-off-by: Jesse Brown <jabrown85@gmail.com>
@jabrown85 jabrown85 requested a review from a team as a code owner February 2, 2021 21:14
@github-actions github-actions bot added this to the 0.17.0 milestone Feb 2, 2021
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Feb 2, 2021
@dfreilich dfreilich changed the base branch from main to release/0.17.0-rc2 February 3, 2021 08:06
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like

@dwillist dwillist merged commit d9cb4e7 into buildpacks:release/0.17.0-rc2 Feb 3, 2021
@dfreilich dfreilich removed the type/chore Issue that requests non-user facing changes. label Feb 3, 2021
edmorley added a commit to edmorley/pack that referenced this pull request Mar 30, 2021
Heroku-20 is now Heroku's default stack, and was previously
added to the suggested builders list in buildpacks#1052, however was
was not yet listed in the suggested stacks list.

See:
/~https://github.com/heroku/pack-images#heroku-pack-base-images
edmorley added a commit to edmorley/pack that referenced this pull request Mar 30, 2021
Heroku-20 is now Heroku's default stack, and was previously
added to the suggested builders list in buildpacks#1052, however was
was not yet listed in the suggested stacks list.

See:
/~https://github.com/heroku/pack-images#heroku-pack-base-images

Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
edmorley added a commit to edmorley/pack that referenced this pull request Mar 30, 2021
Heroku-20 is now Heroku's default stack, and was previously
added to the suggested builders list in buildpacks#1052, however was
was not yet listed in the suggested stacks list.

See:
/~https://github.com/heroku/pack-images#heroku-pack-base-images

Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants