Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to cache volumes #1039

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Add labels to cache volumes #1039

merged 3 commits into from
Jan 27, 2021

Conversation

dwillist
Copy link
Contributor

Signed-off-by: dwillist dthornton@vmware.com

Summary

Adds human readable info to pack volumes.

Output

previously pack volumes were named with a sha256 and had the form <sha256>.<prefix>
now they will be of the form
pack-cache-<repo>-<name>-<tag>-sha256.<prefix>

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • [ x ] No

Resolves #317

Signed-off-by: dwillist <dthornton@vmware.com>
@dwillist dwillist requested a review from a team as a code owner January 26, 2021 14:22
@github-actions github-actions bot added this to the 0.17.0 milestone Jan 26, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #1039 (b48bbe1) into main (ddaff10) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   80.22%   80.24%   +0.03%     
==========================================
  Files         130      130              
  Lines        7989     7993       +4     
==========================================
+ Hits         6408     6413       +5     
+ Misses       1161     1160       -1     
  Partials      420      420              
Flag Coverage Δ
os_linux 79.55% <100.00%> (+0.05%) ⬆️
os_macos ?
os_windows 80.15% <100.00%> (+0.05%) ⬆️
unit 79.55% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dfreilich dfreilich changed the title add image info to cache volumes Add labels to cache volumes Jan 26, 2021
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

 $  docker volume ls
DRIVER    VOLUME NAME
local     pack-cache-b07b36ffb1de.build
local     pack-cache-b07b36ffb1de.launch

After:

local     pack-cache-dfreilich_test-noop_latest-4e450adbfda1.build # ghcr publish
local     pack-cache-dfreilich_test-noop_latest-a17094201004.build # docker publish
local     pack-cache-library_test-noop_latest-b07b36ffb1de.build # local docker build
local     pack-cache-library_test-noop_latest-b07b36ffb1de.launch. #local docker build

Overall, this definitely seems to do what it set out to do. I have some quibbles about the presentation (library isn't super clear, and perhaps we should keep the entire registry string), but overall I think it's definitely a great start, and we can iterate on it as we need.

name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels to pack volumes (to help association/purging)
2 participants