Make compatible with pack 0.3.0 #154
Conversation
ameyer-pivotal
force-pushed
the
more-dist-spec-updates
branch
from
c3fe218 to
160af39
Compare
sclevine
force-pushed
the
dist-spec-and-build-plan
branch
7 times, most recently
from
6e07d44 to
58b8064
Compare
ameyer-pivotal
force-pushed
the
more-dist-spec-updates
branch
2 times, most recently
from
ea67f9e to
9b65887
Compare
| @@ -43,9 +44,16 @@ func main() { | |||
| } | |||
|
|
|||
| func detect() error { | |||
| order, err := lifecycle.ReadOrder(orderPath) | |||
| order, err := compat.ReadOrder(orderPath, buildpacksDir) | |||
There was a problem hiding this comment.
nit: should we read the new order format first and then fall back to the old format if the length is 0? It seems like that would be more in keeping with an "ident the error handling" philosophy
| return order, nil | ||
| } | ||
|
|
||
| type buildpackTOML struct { |
There was a problem hiding this comment.
Do we need a compat definition of buildpackToml and buildpack, it looks like the differences between the definitions and the ones in lifecycle.go and these are purely additive
There was a problem hiding this comment.
I am gonna assume this is for the sake of isolating the compat work in a package and avoiding import cycles.
| } | ||
|
|
||
| if len(matchVersions) > 1 { | ||
| return "", errors.Errorf("too many buildpacks with matching ID '%s'", bpRef.ID) |
There was a problem hiding this comment.
I think we should something specific about "latest" in this error message. Given that there is no requirement that only one version of a buildpack can exist on a builder and in contexts like --buildpack <id> it might not be obvious what the issue is.
sclevine
force-pushed
the
dist-spec-and-build-plan
branch
from
58b8064 to
a13fe0a
Compare
Signed-off-by: Andrew Meyer <ameyer@pivotal.io> Signed-off-by: Javier Romero <jromero@pivotal.io>
sclevine
force-pushed
the
more-dist-spec-updates
branch
from
9b65887 to
ccb05b2
Compare
Signed-off-by: Andrew Meyer ameyer@pivotal.io
Added
compatpackage that's pretty self-contained and can be easily removed when we no longer want this functionality.