Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bugsnag Integrity header to Expo delivery #1133

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Add Bugsnag Integrity header to Expo delivery #1133

merged 2 commits into from
Nov 19, 2020

Conversation

imjoehaines
Copy link
Contributor

Goal

Adds the Bugsnag-Integrity header to Expo delivery, using expo-crypto to calculate the sha1 hash of the payload

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Nov 18, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.57 kB 12.52 kB
After 40.57 kB 12.52 kB
± No change No change

Generated by 🚫 dangerJS against 9cee021

@imjoehaines imjoehaines force-pushed the bugsnag-integrity-header-expo branch from dfa5122 to 9cee021 Compare November 18, 2020 11:21
@imjoehaines imjoehaines marked this pull request as ready for review November 18, 2020 13:21
bengourley
bengourley approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from maybe the exact version.

@imjoehaines imjoehaines merged commit 10e7b03 into integration/bugsnag-integrity-header Nov 19, 2020
@imjoehaines imjoehaines deleted the bugsnag-integrity-header-expo branch November 19, 2020 16:27
@bengourley bengourley mentioned this pull request Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imjoehaines @bugsnagbot @bengourley