Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android to v5.2.3 #1119

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Update android to v5.2.3 #1119

merged 3 commits into from
Nov 4, 2020

Conversation

fractalwrench
Copy link
Contributor

Goal

Updates Android to /~https://github.com/bugsnag/bugsnag-android/releases/tag/v5.2.3 for the latest bug fixes.

This should also substantially reduce the flakiness of the React Native CI pipeline, so it may be worth rebasing any long-running branches.

@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.57 kB 12.52 kB
After 40.57 kB 12.52 kB
± No change No change

Generated by 🚫 dangerJS against 1c6bfc9

@fractalwrench fractalwrench marked this pull request as ready for review November 4, 2020 13:47
@@ -25,3 +25,6 @@ cp -r $MAVEN_REPO_DIR $AAR_DST
echo "Recording version"
rm -rf ./android/.bugsnag-android-version
echo $(cd $ANDROID_REPO_DIR && git rev-parse HEAD) >> ./android/.bugsnag-android-version

sed -i '' "s/api \"com.bugsnag:bugsnag-android:.*/api \"com.bugsnag:bugsnag-android:$AMENDED_VERSION\"/" android/build.gradle
sed -i '' "s/api \"com.bugsnag:bugsnag-plugin-react-native:.*/api \"com.bugsnag:bugsnag-plugin-react-native:$AMENDED_VERSION\"/" android/build.gradle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fractalwrench fractalwrench merged commit 63e0cfb into next Nov 4, 2020
@fractalwrench fractalwrench deleted the update-android-dep branch November 4, 2020 16:07
@imjoehaines imjoehaines mentioned this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants