-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a callback for filtering breadcrumbs #237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dcrumb callback, expose necessary fields via getters
Pull Request Test Coverage Report for Build 1081
💛 - Coveralls |
bengourley
reviewed
Feb 2, 2018
* @param breadcrumb the breadcrumb to be captured by Bugsnag | ||
* @see Breadcrumb | ||
*/ | ||
boolean send(@NonNull Breadcrumb breadcrumb); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is send
the best name for it? If I understand correctly, this method decides if it will "save" not "send" the breadcrumb. I'd call it something like shouldSave(breadcrumb)
.
Updated names in response to feedback from Duncan |
kattrali
approved these changes
Feb 9, 2018
lemnik
pushed a commit
that referenced
this pull request
Jun 2, 2021
Alter bugsnag extension to allow multiple shared object paths
rich-bugsnag
pushed a commit
that referenced
this pull request
Sep 3, 2021
Attach Maze Output as build artifacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a callback which allows a developer to specify whether a breadcrumb should be captured or discarded. This also exposes the
Breadcrumb
class as part of our public API, and allows manipulation of theMetaData
. Some duplication within the Breadcrumbs class has also been removed.Addresses #221