Move instrumentation tests to GitHub actions #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks nice. I think the API 21/24 failure is down to the benchmark tests not really being meant to run on an emulator - so we could either remove that step from CI or keep running it on browserstack.
Left a few other comments inline. The jobs also seem to be cancelled - have these passed originally?
twometresteve
force-pushed
the
tms/github-actions-tests
branch
2 times, most recently
from
9b0b49f to
4e6ccc8
Compare
Co-authored-by: Jamie Lynch <fractalwrench@gmail.com>
twometresteve
force-pushed
the
tms/github-actions-tests
branch
from
4e6ccc8 to
194dd9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
TODO: Resolve failures in API levels 21/24. It's not clear to me why these are failing, although I suspect they won't be hard to resolve.
Move the instrumentation tests to simulator-based GitHub Actions.
Design
We've have various issues running Espresso tests on real devices and the time taken to deal with those has started to outweigh the benefits of running on real devices (given that we run e2e tests on them).
Changeset
Remove Buildkite steps and add new GHA workflow.
Testing
Covered by CI.