Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build example app for Espresso tests #1457

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Build example app for Espresso tests #1457

merged 1 commit into from
Oct 29, 2021

Conversation

twometresteve
Copy link
Contributor

@twometresteve twometresteve commented Oct 25, 2021

Goal

Ensure example app is built for the instrumentation tests. Also reenable the steps in the pipeline, as Espresso tests now seem to be working on BrowserStack.

Testing

Covered by CI, although I would await confirmation of the Espresso test fix from BrowserStack before merging.

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Oct 25, 2021

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1281.07 1166.37
arm64_v8a 410.0 299.4
armeabi -492.59 -21.55
armeabi_v7a 381.33 270.74
x86 450.94 336.25
x86_64 434.56 323.97

Generated by 🚫 Danger

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but we should run this a few times and possibly wait over a couple of days to confirm the problem has been resolved.

@twometresteve twometresteve merged commit f3ba69b into next Oct 29, 2021
@twometresteve twometresteve deleted the tms/espresso-fix branch October 29, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants