Prevent potential SHA-1 hash mismatch in Bugsnag-Integrity header #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
PLAT-5579/integrity-header
branch
from
adf7047 to
2df65ca
Compare
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevents a SHA-1 hash mismatch when the React Native notifier changes the
notifierfield on startup. Because the Android notifier assigns the event payload value by reference fromClient#notifier, the request payload can change between generating a SHA-1 hash and making the request.Changeset
Copied the
notifierparameter when constructing anEventPayload, so that it does not hold a copy of global state.Testing
Added unit test to verify that the
notifierproperty is always copied when constructing anEventPayload. Additionally ran artefact against failing React Native scenario and confirmed that this change fixes the immediate issue.