Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ng test work #30

Closed
mvollebregt opened this issue Jun 13, 2020 · 3 comments · Fixed by #41
Closed

Make ng test work #30

mvollebregt opened this issue Jun 13, 2020 · 3 comments · Fixed by #41

Comments

@mvollebregt
Copy link

Is your feature request related to a problem? Please describe.

This is an awesome schematic. It would be even more awesome, if you could run the jest specs by entering ng test. After adding the jest-schematic, ng test does not run the tests anymore.

Describe the solution you'd like

Make the jest-schematic:

  • install @angular-builders/jest (npm i -D jest @types/jest @angular-builders/jest)
  • in angular.json, replace @angular-devkit/build-angular:karma with @angular-builders/jest:run
@brianpooe
Copy link

@mvollebregt why wont you create a PR for this seems like you already know what the solution is, amd see if they agree with it for a merge.

@mvollebregt
Copy link
Author

I had a short look at it before, but I had some trouble finding out how the schematics worked. I'll see if I have some more time later to dive into that. In the meanwhile, I just wanted to explain the improvement, in case someone happened to be able to fix it easily.

schuchard added a commit that referenced this issue Sep 2, 2020
Add support single application projects and workspaces with apps and libraries. 

## Jest runner

Replace the direct reliance on [`jest-preset-angular`](/~https://github.com/thymikee/jest-preset-angular) and package json scripts in favor of [`angular-builders/jest`](/~https://github.com/just-jeb/angular-builders/tree/master/packages/jest). This provides the ability to run tests with `ng test`

This should address #30 #28 #22 #11 
It better positions us to support #1 

## Jest types

Update each projects `tsconfig.spec.json` to configure the `jest` types while removing `jasmine`

This should address #24 #14

## Other
Non-user facing changes 

- refactor development scripts from `package.json` to TS file
- create 2 sandboxes (single app and workspace with app and lib)
- test both sandboxes during CI
- add MIT license
- add prettier
@schuchard
Copy link
Collaborator

Please try ng add @briebug/jest-schematic@3.0.0-0 which adds this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants