Address security concern dapps

[qamarngr]

Resolves brave/brave-browser#21798
Resolves brave/brave-browser#22913

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • /~https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • /~https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • /~https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • /~https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • /~https://github.com/brave/brave-browser/wiki/Custom-Headers
  • /~https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • /~https://github.com/brave/brave-browser/wiki/QA-Guide
  • /~https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Same as in PR

[Pavneet-Sing]

Try to use domain layer as much as possible to avoid future refactoring.
BTW, the iOS CI is failing, seems like some tests are failing, Cross check with @SergeyZhukovsky or iOS team.
[Update]: IOS CI issues is in progress.

[Pavneet-Sing]

While you are on signature panel, Could you also please add some bottom padding to the description and close the brave/brave-browser#22913 ticket, TIA.

[qamarngr]

Try to use domain layer as much as possible to avoid future refactoring. BTW, the iOS CI is failing, seems like some tests are failing, Cross check with @SergeyZhukovsky or iOS team. [Update]: IOS CI issues is in progress.

I'll start using domain layer from my next ticket, I just wanted to develop little more understanding around it.

[SergeyZhukovsky]

++ but please remove unused
private BraveWalletService mBraveWalletService;
before merge

[qamarngr]

iOS CI failed because of a known problem not related to that PR

[srirambv]

Verification passed on Oppo Reno 5 with Android 12 running 1.41.18 custom Dapp support build

• Verified steps from #12701
• Verified eTLD+1 is shown in bold on panel while transacting with a Dapp

[mkarolin]

wallet's?

[bbondy]

yes @qamarngr could you pls fix and uplift?

[mkarolin]

Same in IDS_BRAVE_WALLET_PROVIDE_ENCRYPTION_KEY_TITLE in components/resources/wallet_strings.grdp

[bbondy]

It also looks like this string isn't using a proper variable for the origin in question. Languages can't be translated 1:1 via concatenation like that

[qamarngr]

@bbondy will fix it this

[qamarngr]

@mkarolin What should be fixed in IDS_BRAVE_WALLET_PROVIDE_ENCRYPTION_KEY_TITLE

[qamarngr]

https://ci.brave.com/job/brave-core-create-uplift-prs/1917/