Fix #40 - Hidden document viewer does not load pages in Firefox #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @lakenen has signed the CLA. Thanks for the pull request! |
There is a bug in Firefox where `window.getComputedStyle()` returns null if called in a hidden (`display:none`) iframe (https://bugzilla.mozilla.org/show_bug.cgi?id=548397), so we fallback to a default value if this happens.
|
👍 |
lakenen
added a commit
that referenced
this pull request
Jun 2, 2014
Fix #40 - Hidden document viewer does not load pages in Firefox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in Firefox where
window.getComputedStyle()returns null if called in a hidden (display:none) iframe (https://bugzilla.mozilla.org/show_bug.cgi?id=548397), so we fallback to a default value if this happens.