Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors inside 'ready' callback are silenced #37

Closed
aehlke opened this issue May 27, 2014 · 3 comments
Closed

Errors inside 'ready' callback are silenced #37

aehlke opened this issue May 27, 2014 · 3 comments

Comments

@aehlke
Copy link

aehlke commented May 27, 2014

Once instantiating a viewer, this code will fail silently without raising any error visible in the browser console - this cost us a few hours of time that would have been saved had we seen it in the console. It seems to be swallowed inside viewer.js.

            docviewer.on('ready', function (e) {
                my_undefined_var.foo();
            });

Thanks!

@lakenen
Copy link
Contributor

lakenen commented May 27, 2014

Thanks for reporting this. I'm surprised I hadn't noticed this myself, but I guess that makes sense due to the nature of the issue. At first glance it appears that jQuery promises are swallowing all exceptions, but I need to dig in a bit more to be sure.

@aehlke
Copy link
Author

aehlke commented May 27, 2014

Appreciate you taking the time for "hygienic" improvements :)

@lakenen
Copy link
Contributor

lakenen commented May 27, 2014

Turns out it was a bug my implementation of ajax requests. Thanks again for reporting!

lakenen added a commit that referenced this issue May 28, 2014
Fix #37 - exceptions thrown in AJAX request handler are swallowed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants