twoliter: use grub-bios-setup from SDK #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`grub-bios-setup` is a host program; if it's installed from a package that came from a kit, it may have been built for a different host architecture. Signed-off-by: Ben Cressey <bcressey@amazon.com>
|
Leaving in draft until an official SDK build with the required change is out. |
jpculp
approved these changes
May 28, 2024
webern
approved these changes
May 29, 2024
cbgbt
approved these changes
Jun 10, 2024
|
The Bottlerocket SDK v0.42.0 has been released. /~https://github.com/bottlerocket-os/bottlerocket-sdk/releases/tag/v0.42.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #225
Description of changes:
Rely on
grub-bios-setupfrom the SDK. Depends on bottlerocket-os/bottlerocket-sdk#183.Testing done:
Applied this change and switched to a custom SDK. Verified that I could build an x86_64 image and boot on a system using BIOS firmware.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.