Add variant override to updog arguments #923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If --variant is given, updog will use its argument to look for updates, rather
than the currently running variant. This allows for manually changing between
variants that you know are compatible.
Implementation note: running_version() was removed so that the current variant
isn't as easily used by accident when the user intended to override it.
Testing done:
Starting with a 1.15 AMI with this change:
A 1.16 image in a test repo only shows up when --variant is specified:
Updates OK:
...reboot, reconnect...
Instance is
running
, connects to my cluster, and runs a pod OK.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.