update systemd to v245 #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd's repart utility depends on libfdisk. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Applying the %license attribute to a file with a relative path causes it to be copied into a directory named for the parent package. By using an absolute path, we can arrange for subpackages to include their own copy of the corresponding license. Signed-off-by: Ben Cressey <bcressey@amazon.com>
iliana
reviewed
Apr 21, 2020
| @@ -187,7 +188,7 @@ dd if="${PRIVATE_IMAGE}" of="${DISK_IMAGE}" conv=notrunc bs=1M seek=2005 | |||
| # BOTTLEROCKET-DATA | |||
| truncate -s 1G "${DATA_IMAGE}" | |||
| sgdisk --clear \ | |||
| -n 0:1M:1023M -c 0:"BOTTLEROCKET-DATA" -t 0:8300 \ | |||
| -n 0:1M:1023M -c 0:"BOTTLEROCKET-DATA" -t 0:"${BOTTLEROCKET_DATA_TYPECODE}" \ | |||
There was a problem hiding this comment.
Any particular reason why we don't want to use the standard "Linux data" partition label?
There was a problem hiding this comment.
I wanted to leave that for other disks that might show up, like EBS volumes.
iliana
approved these changes
Apr 21, 2020
tjkirch
approved these changes
Apr 21, 2020
bcressey
force-pushed
the
systemd-update
branch
2 times, most recently
from
54ac459 to
28ad365
Compare
tjkirch
approved these changes
Apr 21, 2020
This syncs the build options with changes between 240 and 245. We also enable the repart tool and its dependencies. Although repart only supports the root device today, it could be useful when we add support for an initrd, or when we have variants with only one block device. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Features related to passwords and emergency debugging assume that an interactive shell will be present for use on the console. Variants that do not include a shell also do not need the related files. The new sulogin helper enables the single-user login shell to work as expected for development and debugging purposes. Signed-off-by: Ben Cressey <bcressey@amazon.com>
This allows tools to find the partition by UUID as well as by label. Signed-off-by: Ben Cressey <bcressey@amazon.com>
This fixes a potential upgrade issue for systemd 245, where oneshots should have RemainAfterExit=yes so that they are not started again after they exit successfully. Signed-off-by: Ben Cressey <bcressey@amazon.com>
bcressey
force-pushed
the
systemd-update
branch
from
28ad365 to
928db81
Compare
tjkirch
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#865
Description of changes:
Updates systemd to v245. Enables the
reparttool for declarative repartitioning. Syncs build options. Shifts relevant files into theconsolesubpackage.Adds
libfdiskpackage toutil-linux, needed as a dependency forrepart. Fixes license files.Minor tweak to
releaseto fix an upgrade issue withprepare-local. Minor tweak torpm2imgto assign a fixed UUID to the data partition.Testing done:
Built
aws-devvariant and tested locally.Confirmed that:
/usr/lib/systemd/systemd-sulogin-shell debugworks to start a debug shellsystemd-repartcan add or grow a partition on the root device/usr/share/licensesforutil-linuxsubpackages.Built
aws-k8s-1.15variant and tested in a cluster. Confirmed thatsonobuoytests pass.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.