apiserver: update to actix 2.0 #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
approved these changes
Feb 28, 2020
bcressey
approved these changes
Feb 29, 2020
|
Rebase on develop, to get #805 so dependencies of removed code don't come into play. |
hyperlocal hasn't been updated to use the new hyper, so we switch to hyper-unix-connector, which is essentially the same thing.
This is a `cargo update`, followed by updating dependencies found through `cargo outdated -w` and removing unused dependencies found by `cargo +nightly udeps --workspace`. The manual updates are: * nix to 0.17; no important changes * http to 0.2; no important changes * reqwest to 0.10; we now use the 'blocking' module since we only use reqwest synchronously * gptman to 0.6.1; no important changes
apiclient: update to use new futures, hyper, and tokio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I'm working on updating all of our dependencies, and this one is a bigger change than most, so I split it out. actix went async in 2.0, so we had some code changes here to accommodate. Nothing that impacts our logic, just some infectious "async" and "await" keywords, and a couple function signature changes.
Testing done:
Unit tests pass. Ran the apiserver and (not-updated) apiclient locally. Checked settings, PATCHed settings in a named transaction, committed them, saw updated settings.