clean up CNI results cache on boot #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The network device configurations referenced in the results do not persist across reboot, so the cache isn't useful. Malformed or empty files can also cause errors that interfere with subsequent operations on pod sandboxes. Signed-off-by: Ben Cressey <bcressey@amazon.com>
yeazelm
approved these changes
Feb 21, 2024
arnaldo2792
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related: containerd/containerd#8197
Description of changes:
The network device configurations referenced in the results do not persist across reboot, so the cache isn't useful. Malformed or empty files can also cause errors that interfere with subsequent operations on pod sandboxes.
Testing done:
Verified that
/var/lib/cni/resultswas cleaned up on reboot:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.