-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.14.x] cherry-pick: update SDK to 0.33.0 #3225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also need 67c7bd7 for the 0.33.0 bump. |
Signed-off-by: Ben Cressey <bcressey@amazon.com> (cherry picked from commit 67c7bd7)
Signed-off-by: Ben Cressey <bcressey@amazon.com> (cherry picked from commit 6aed1b9)
This causes the RPM package architecture to match the target's rather than the host's. By default, `dnf` and `rpm` will ignore non-native RPMs, but both can be forced to use them. When the package architecture is set correctly, it's not necessary to include the architecture in the package name, and the macros in the SDK no longer do so. Fix up various places in the image build process that assumed the architecture would be present. Signed-off-by: Ben Cressey <bcressey@amazon.com> (cherry picked from commit 78013d3)
This was used as a quick way to disable debuginfo generation, but it creates ambiguity when using the RPM's architecture to indicate what target the package was built for. These packages capture the architecture in the sysroot-based paths used for installed files, so they are not actually arch-agnostic in the sense that "noarch" implies. Signed-off-by: Ben Cressey <bcressey@amazon.com> (cherry picked from commit 827c051)
Signed-off-by: Ben Cressey <bcressey@amazon.com> (cherry picked from commit 39cd56a)
Signed-off-by: Ben Cressey <bcressey@amazon.com> (cherry picked from commit 70362d3)
etungsten
force-pushed
the
cherrypick-3213
branch
from
June 23, 2023 20:48
bfee24a
to
7e89d7f
Compare
Push above adds the missing commit |
jpculp
approved these changes
Jun 23, 2023
Do we need to manually bust the cache to clean things up? |
stmcginnis
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
See #3213
Testing done:
See #3213
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.