kubelet.service: change the restart policy to always #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrow
approved these changes
Feb 2, 2023
webern
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Makes sense to me. @etungsten do you foresee any issues with this change?
etungsten
reviewed
Feb 3, 2023
stmcginnis
approved these changes
Feb 7, 2023
etungsten
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2512
Description of changes:
currently we only specify kubelet to be restarted when it on failure. However, the situation resources starvation evicts kubelet isn't recognized as failure, so kubelet won't be restarted on this situation. Therefore, setting kubelet restart policy to
alwayscan solve this issue.Testing done:
- launch small instance and add heavy computable pods to the cluster
been
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.