Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsys: Use builder for EKS CRD creation #2724

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

ecpullen
Copy link
Contributor

@ecpullen ecpullen commented Jan 10, 2023

Previously there was a bug with the builder that prevented it from being used with for EKS crd creation. That bug was resolved in v0.0.5. The error type from the builder was also fixed, so snafu could be used.

Issue number:

N/A

Description of changes:

 testsys: Use `builder` for EKS CRD creation
    
    Previously there was a bug with the builder that prevented it from being
    used with for EKS crd creation. That bug was resolved in v0.0.5. The
    error type from the builder was also fixed, so snafu could be used.

Testing done:

cargo make test

 NAME                                 TYPE        STATE        PASSED    SKIPPED    FAILED   LAST UPDATE              BUILD ID
 x86-64-aws-k8s-124                   Resource    completed                                   2023-01-10T14:58:48Z    3ebb33a9
 x86-64-aws-k8s-124-instances-hdji    Resource    completed                                   2023-01-10T14:58:59Z    3ebb33a9
 x86-64-aws-k8s-124-test              Test        pass         1         6972       0         2023-01-10T15:00:32Z    3ebb33a9

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Previously there was a bug with the builder that prevented it from being
used with for EKS crd creation. That bug was resolved in v0.0.5. The
error type from the builder was also fixed, so snafu could be used.
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ecpullen ecpullen merged commit 42ce2ba into bottlerocket-os:develop Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants