-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable IAM Roles Anywhere with the k8s ecr-credential-provider
plugin
#2553
Merged
stmcginnis
merged 1 commit into
bottlerocket-os:develop
from
stmcginnis:iam-roles-anywhere
Nov 11, 2022
Merged
Enable IAM Roles Anywhere with the k8s ecr-credential-provider
plugin
#2553
stmcginnis
merged 1 commit into
bottlerocket-os:develop
from
stmcginnis:iam-roles-anywhere
Nov 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Nov 9, 2022
stmcginnis
force-pushed
the
iam-roles-anywhere
branch
2 times, most recently
from
November 9, 2022 23:24
50f92e6
to
652a54f
Compare
webern
approved these changes
Nov 10, 2022
webern
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can't be merged until the source is pushed to the lookaside cache and the version tag is obtained.
webern
approved these changes
Nov 10, 2022
stmcginnis
force-pushed
the
iam-roles-anywhere
branch
from
November 11, 2022 17:50
652a54f
to
82e8bbc
Compare
stmcginnis
force-pushed
the
iam-roles-anywhere
branch
from
November 11, 2022 17:53
82e8bbc
to
bd5ffac
Compare
webern
approved these changes
Nov 11, 2022
jpmcb
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! 👏🏼
❯ sha512sum rolesanywhere-credential-helper-v1.0.2.tar.gz
b364bf8f73f33e7ac1db6a1153880ffa2e4af52a3d8f7b224cc5a9a2e545432a9bf408191048a406fdb995a034b997cdeeb752b4dfcea8288be5baeca8e69b9a rolesanywhere-credential-helper-v1.0.2.tar.gz
bcressey
approved these changes
Nov 11, 2022
This adds a new package to place the `aws_signing_helper` binary in the /usr/bin PATH to enable its use for k8s credential provider support of IAM Roles Anywhere. This adds documentation to our README settings docs to give an example of how to configure IAM Roles Anywhere support with the k8s image credential provider plugin. Signed-off-by: Sean McGinnis <stmcg@amazon.com>
stmcginnis
force-pushed
the
iam-roles-anywhere
branch
from
November 11, 2022 19:08
bd5ffac
to
62cc271
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2310
Description of changes:
This adds a new package to place the
aws_signing_helper
binary in the /usr/bin PATH to enable its use for k8s credential provider support of IAM Roles Anywhere.Documentation also added to give an example of how to configure the AWS client settings to use this.
Testing done:
Deployed node and verified
aws_signing_helper
is present and executable in the/usr/bin
directory.Additional testing TBD with the EKS-A team to validate functionality.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.