sync file timestamps for module bundle #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Cressey <bcressey@amazon.com>
Otherwise `cargo` will detect that the file is newer than the output log, and always rebuild. Signed-off-by: Ben Cressey <bcressey@amazon.com>
etungsten
approved these changes
Sep 16, 2022
stmcginnis
approved these changes
Sep 16, 2022
jpculp
approved these changes
Sep 16, 2022
arnaldo2792
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #2429
Description of changes:
Avoid spurious rebuilds by syncing the bundle's timestamp with the input file.
Also, replace all
unwrap()calls with structured errors that have context-specific messages.Testing done:
Repeated
cargo makeinvocations no longer cause an unnecessary rebuild.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.