infrasys: update to AWS SDK Rust #2414
Conversation
|
Opening draft on @rpkelly's behalf. We'll want to merge around the same time that we transition pubsys. |
tools/Cargo.lock
Outdated
| @@ -46,9 +46,9 @@ dependencies = [ | |||
|
|
|||
| [[package]] | |||
| name = "anyhow" | |||
| version = "1.0.58" | |||
There was a problem hiding this comment.
Do we want the updated packages in a separate commit?
rpkelly
force-pushed
the
aws-sdk-rust-infrasys
branch
3 times, most recently
from
e1f3202 to
167da43
Compare
There was a problem hiding this comment.
With this change, we should be able to remove L66-67 in tools/deny.toml.
tools/infrasys/src/shared.rs
Outdated
| @@ -32,23 +32,27 @@ pub async fn get_stack_outputs( | |||
| cfn_client: &CloudFormationClient, | |||
| stack_name: &str, | |||
| region: &str, | |||
| ) -> Result<Vec<rusoto_cloudformation::Output>> { | |||
| ) -> Result<Vec<aws_sdk_cloudformation::model::Output>> { | |||
There was a problem hiding this comment.
What we probably want is something like
use aws_sdk_cloudformation::output::DescribeStacksOutput;
and then have
Result<Vec<DescribeStacksOutput>>
There was a problem hiding this comment.
imported outputs at the top. Outputs is actually the type we want to return here.
There was a problem hiding this comment.
Ah, I see it changes from DescribeStacksOutput when you get to the .stacks.
Output seems very non-descriptive though and could conflict with something else down the road. Would it be better to do use aws_sdk_cloudformation::model::{Output as CfnOutput, Parameter}?
rpkelly
force-pushed
the
aws-sdk-rust-infrasys
branch
2 times, most recently
from
e7c6955 to
a04c80d
Compare
Co-authored-by: Patrick J.P. Culp <jpculp@amazon.com>
rpkelly
force-pushed
the
aws-sdk-rust-infrasys
branch
from
a04c80d to
19fb48c
Compare
Issue number:
#1968
Description of changes:
Replaces rusoto with aws-sdk-for-rust in infrasys.
Testing done:
Coming soon!
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.