-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
models, kubernetes: add new provider-id setting #2192
models, kubernetes: add new provider-id setting #2192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would aws-* users want this to be set by early-boot-config to the instance id? Maybe I misunderstand its purpose. |
No, this is mostly for nodes operating in a cluster without a cloud-provider (e.g. a baremetal on-prem cluster). Normally cloud-providers (like AWS EKS) would be setting the providerID directly in the node.spec of the node when it initializes. In environments where such cloud-provider does not exist, kubelet has the ability to set the |
e21eb72
to
f9433ab
Compare
Push above rebases onto develop |
This adds a new `settings.kubernetes.provider-id` setting for configuring the `providerID` item in kubelet config.
We added a new setting for configuring kubelet's provider-id option.
f9433ab
to
08e2fc1
Compare
Push above adds kubelet providerID configuration to 1.23's kubelet config. |
Issue number:
N/A
Description of changes:
Testing done:
Built and ran metal-k8s-1.22.
The node joins the cluster without problem.
When I updated the
settings.kubernetes.provider-id
setting, the config gets rendered correctly:Kubelet also successfully restarts and reregisters the node fine:
If I set the setting in userdata:
kubelet runs fine and registers the node with providerID as expected:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.