docs: Update cargo-make commands so that tasks come after arguments #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change in `cargo-make` v0.35.3, arguments like `-e PUBLISH_REGION` must be passed before the task name (instead of after).
jpculp
force-pushed
the
cargo-make-ami-fix
branch
from
63a10f0 to
0f2bcc6
Compare
jpculp
changed the title
|
Updated to address all instances of tasks before arguments. |
etungsten
approved these changes
Nov 2, 2021
bcressey
approved these changes
Nov 2, 2021
tjkirch
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1796
Description of changes:
Due to a change in
cargo-makev0.35.3, arguments like-e PUBLISH_REGIONmust be passed before the task name (instead of after).Testing done:
Built, published, and ran
aws-k8s-1.20AMI without anInfra.tomlfile.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.