netdog: Add IP validation to node_ip()
#1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
approved these changes
Jul 30, 2021
arnaldo2792
reviewed
Jul 30, 2021
Previously the `node-ip` subcommand, which runs the `node_ip()` function, would read the current IP from file and return it directly as JSON. This change validates what we read from the file is an actual proper IP address.
|
^ changed |
bcressey
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Requested in #1664
Description of changes:
Testing done:
aws-k8s-1.19node, it joins the cluster and runs a pod just fine./var/lib/netdog/current_ipto an invalid IP1.2.3, runnetdog node-ipby hand and (correctly) receive an error.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.