fix build-kmod-kit build failure #1357
Conversation
There was a problem hiding this comment.
It might be worth updating the commit message to have a bit more data. For reference, some hosts might have the net.ipv4.ip_forward sysctl set to 0, but we still want those hosts to be able to build Bottlerocket.
Given that the image in question is the SDK image, the script isn't doing anything funky, and we're running inside the container as non-root this looks fine to me.
Sure, Would update the commit message. Thanks! |
Added description to commit message |
Some hosts might have the net.ipv4.ip_forward sysctl set to 0, but we still want those hosts to be able to build Bottlerocket. We added --network=host to docker run command to fix this.
Issue number:
NA
Description of changes:
The build was failing on the
build-kmod-kittask on one host with the following errorWARNING: IPv4 forwarding is disabled. Networking will not work. curl: (6) Could not resolve host: cache.bottlerocket.awsAdded a fix
--network=hostto the build-kmod-kit task'sdocker runcommand and it worked..Testing done:
cargo make build-kmod-kitworkedTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.