add aliases for container-selinux types #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This define aliases for the corresponding types in the supplemental container-selinux policy that's widely used. These aliases allow pods and task definitions to specify labels such as `spc_t` and have them also work on Bottlerocket. Signed-off-by: Ben Cressey <bcressey@amazon.com>
Now that we alias `container_file_t` to `local_t` in our policy, we don't need this patch to avoid an invalid context warning. Signed-off-by: Ben Cressey <bcressey@amazon.com>
samuelkarp
approved these changes
Feb 11, 2021
tjkirch
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This aliases
container-selinuxpolicy types such asspc_tto our own policy types.That lets us drop one of the Kubernetes patches we've been carrying for a while, and makes it easier to port pod and task definitions from Amazon Linux to Bottlerocket.
Testing done:
Verified that a pod with
spc_tset in its security context ended up running ascontrol_t.Confirmed that there were no warnings about an invalid
container_file_tcontext with the Kubernetes patch reverted, which was what it was originally intended to fix per 2e111e3.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.