-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting Linux kernel parameters (sysctl) via settings #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us handle quoted keys, e.g. settings.kernel.sysctl."vm.max_map_count"
zmrow
reviewed
Oct 16, 2020
tjkirch
force-pushed
the
sysctl-settings
branch
from
October 16, 2020 17:07
7b999eb
to
28cf627
Compare
^ This push fixes the issues found by @zmrow. |
tjkirch
force-pushed
the
sysctl-settings
branch
from
October 16, 2020 19:29
28cf627
to
7640187
Compare
^ This push fixes some concerns raised by @bcressey:
|
bcressey
approved these changes
Oct 16, 2020
zmrow
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1125
Description of changes:
It would make sense to look at these commits separately.
The Cargo.lock V2 format change is a separate commit so that it's clear there were no real changes to dependencies:
The second commit is a bug fix for schnauzer that's required for sysctl settings; we hadn't previously sent quoted keys through metadata queries:
The main event:
Testing done:
I also used the user data example that I added to README, and saw the instance come up with the two requested sysctl settings set.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.