pubsys-setup: don't require repo section if Infra.toml exists #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user could have set up Infra.toml for other purposes, for example just building images and AMIs, and they don't care about repos. In this case, we can continue and generate role/key for them, as if there's no Infra.toml. Co-authored-by: Zac Mrowicki <mrowicki@amazon.com> Co-authored-by: Tom Kirchner <tjk@amazon.com>
tjkirch
approved these changes
Oct 5, 2020
webern
approved these changes
Oct 5, 2020
bcressey
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes #1143
Description of changes:
Note: The indent caused whitespace changes that makes the GitHub diff hard to read. See this gist: https://gist.github.com/zmrow/56ace20e86deeaec061e60358aebddf4 for the diff without whitespace changes.
The user could have set up Infra.toml for other purposes, for example just
building images and AMIs, and they don't care about repos. In this case, we
can continue and generate role/key for them, as if there's no Infra.toml.
Testing done:
Infra.tomlInfra.tomlwithout areposectionInfra.tomlwith areposectionTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.