pubsys: use requested size for volume, keeping snapshot to minimum size #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The volume size used at instance launch time is determined by the block device mapping, defaulting to the snapshot size. Here we configure the BlockDeviceMappings to use the requested size rather than the snapshot size. The snapshots used to create those volumes, then, don't need to be more than the size of the data inside. (Users creating AMIs based on snapshots from existing AMIs can specify any desired size above the snapshot size in their own block device mappings.)
iliana
approved these changes
Sep 14, 2020
bcressey
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done:
Registered an image. Still see
"VolumeSize": 2for root volume and"VolumeSize": 20for data volume in the block device mappings. When describing the snapshots, however, I now see"VolumeSize": 2and"VolumeSize": 1, respectively.The image launched OK and ran a pod OK. The volumes looked OK, still 20GB for /local.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.