aws-ecs-1: add configurable logging drivers #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Jul 30, 2020
webern
approved these changes
Jul 30, 2020
jahkeup
approved these changes
Jul 30, 2020
bcressey
approved these changes
Jul 30, 2020
The new ecs.logging-drivers setting controls the list of logging drivers available for use with ECS. The defaults are "json-file", "awslogs", and "none". Other logging drivers (such as those installed via a plugin) can be enabled. The default set of logging drivers can be reduced or removed to implement policy for allowable logging drivers in a cluster.
samuelkarp
force-pushed
the
ecs-logging-drivers
branch
from
4fe820c to
9b7955a
Compare
jahkeup
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#815
Description of changes:
The new ecs.logging-drivers setting controls the list of logging drivers available for use with ECS. The defaults are "json-file", "awslogs", and "none". Other logging drivers (such as those installed via a plugin) can be enabled. The default set of logging drivers can be reduced or removed to implement policy for allowable logging drivers in a cluster.
Testing done:
Launched an instance, saw it register with the appropriate capabilities. Ran a task using the awslogs driver, validated that logs appeared in CloudWatch Logs with the correct group and stream. Used apiclient to mutate the list of logging drivers, saw changes rendered in the ECS config file and reflected in DescribeContainerInstances.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.