drop "dependencies" table for all packages #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`buildsys` is only capable of modeling build-time dependencies, and only for dependencies that fall within the current workspace - not anything that comes from a kit. Using the "dependencies" table to track the runtime dependencies of the generated RPMs is superfluous, and likely to be incorrect even for packages that reside in the same workspace. Meanwhile, it cannot work properly for runtime dependencies that come from kits, since the metadata for those packages is not available. Historically, listing these packages as a dependency caused them to be built before the dependent package was used. The "release" package in particular depended on most packages in the workspace, which meant that they would be built even if none of the variants included them as an explicit dependency. Now all the packages in the workspace are expected to be dependencies of the kit that includes them, so this workaround is not necessary. Signed-off-by: Ben Cressey <bcressey@amazon.com>
jmt-lab
approved these changes
Nov 14, 2024
cbgbt
approved these changes
Nov 14, 2024
arnaldo2792
approved these changes
Nov 15, 2024
| @@ -9,47 +9,3 @@ build = "../build.rs" | |||
|
|
|||
| [lib] | |||
| path = "../packages.rs" | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
buildsysis only capable of modeling build-time dependencies, and only for dependencies that fall within the current workspace - not anything that comes from a kit.Using the "dependencies" table to track the runtime dependencies of the generated RPMs is superfluous, and likely to be incorrect even for packages that reside in the same workspace. Meanwhile, it cannot work properly for runtime dependencies that come from kits, since the metadata for those packages is not available.
Historically, listing these packages as a dependency caused them to be built before the dependent package was used. The "release" package in particular depended on most packages in the workspace, which meant that they would be built even if none of the variants included them as an explicit dependency.
Now all the packages in the workspace are expected to be dependencies of the kit that includes them, so this workaround is not necessary.
Testing done:
Built locally.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.