Separation of inputs into separate more maintainable files

[simmerz]

@lcreid this is how I propose to tackle #517 .

I'd like to get this done across all the fields and then figure out if we can DRY any of it up, but perhaps that's a second exercise.

What are your thoughts?

[lcreid]

Thanks for the PR. I have a couple of questions in comments in the PR. It's a good PR, because you're pointing me to what you're thinking, and you're making me think more about what you should be trying to achieve. I'll try to think about this a bit more this weekend. Feel free to answer the questions and further develop the PR if you wish.

P.S. I'm using the "Review" mechanism of GitHub, but please take my comments in the spirit of a conversation, rather than a review.

Thanks again for your contributions!

[simmerz]

@lcreid This has now been updated against latest master

I've taken the liberty of removing the method_alias_chain "clone" file as it can be done more simply as I've demonstrated in this.

I've deliberately not refactored the various field inputs into smaller ones as I think that is a separate job.

[lcreid]

I like what I see. There's a lot of work here, and you obviously have a good grasp of loading, requiring, etc. I've wondered myself whether there were better ways to do things with the new Ruby and Rails that we're supporting nowadays. I also like how you cleaned up the redundancy around the methods that are similar.

Still, I'd like to take a longer look at it (sorry for the delay already, but paid work has to come first, I'm afraid).

In the meantime, I've realized that we didn't have any tests to test for the "_without_bootstrap" methods. Since you've changed the implementation of that, it would be worthwhile to add at least one test of a "_without_bootstrap" method, if for no other reason, than to record that it's a requirement. E.g.

test "text fields are wrapped correctly" do
  expected = <<-HTML.strip_heredoc
    <input id="user_email" name="user[email]" type="text" value="steve@example.com" />
  HTML
  assert_equivalent_xml expected, @builder.text_field_without_bootstrap(:email)
end

That may not be exactly right, but should give you the idea of what I'm suggesting.

Thanks again. Great work!

[lcreid]

Thanks for the PR! This is great work! Overall I think it's going to be a lot easier to maintain bootstrap_form with this. I'm looking forward to not having to scroll up and down so much :-).

I made a few comments, but they're really questions to satisfy my curiosity.

Thanks again for the good work!

[simmerz]

In the meantime, I've realized that we didn't have any tests to test for the "_without_bootstrap" methods. Since you've changed the implementation of that, it would be worthwhile to add at least one test of a "_without_bootstrap" method, if for no other reason, than to record that it's a requirement. E.g.

Added a test just like this