This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
do not grow dbsize agressively #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only grow the database size when the high watermark increases. We also grows the database size a little bit aggressively to save a few ftruncates. I have tested this on various environments. The performance impact is ignorable with 16MB over allocation. Without over allocation, the performance might decrease 100% when each Tx.Commit needs a new page on a very slow disk (seek time dominates the total write).
| // do not over allocate | ||
| if sz > db.datasz { | ||
| sz = db.datasz | ||
| } |
There was a problem hiding this comment.
What if sz < db.datasz ?
Why add overAllocation and then discard it ?
There was a problem hiding this comment.
I moved overAllocation to DB.AllocSize in a122e1c so it can be configurable.
|
Kindly ping @benbjohnson. Following up with #472, etcd needs this patch as well. It would be great if you can take a look at this. Thanks! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only grow the database size when the high watermark increases.
We also grows the database size a little bit aggressively to
save a few ftruncates and fsyncs.
I have tested this on various environments. The performance impact
is ignorable with 16MB over allocation. Without over allocation,
the performance might decrease 100% when each Tx.Commit needs a new
page on a very slow disk (seek time dominates the total write).
We will not overallocate 16MB when the database is small since it also
limits by the datasz.