Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drop command for kv store #322

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Fix drop command for kv store #322

merged 3 commits into from
Feb 6, 2025

Conversation

matthewpeterkort
Copy link
Collaborator

@matthewpeterkort matthewpeterkort commented Feb 5, 2025

Fixes an issue when doing a grip drop graphName-> grip create graphName if using the pebble driver, the docs don't get deleted and a grip list labels graphName will still return the old labels of the old graph if using the same graphName.

Swaps the driver that the go tests use to the pebble driver since that is the driver that fails the test without the updates in this PR.

This PR leaves the documents themselves in tact, but there aren't any indices linking the documents to anything.

@matthewpeterkort matthewpeterkort changed the title [WIP] Fix drop command for kv store Fix drop command for kv store Feb 6, 2025
@kellrott
Copy link
Member

kellrott commented Feb 6, 2025

LGTM

@kellrott kellrott merged commit 96023b5 into develop Feb 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants