[Fix] print_matrix #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we enter float value inside cost matrix, "print_matrix" function
treats those values as integer, and only prints integral part of the
values.
For example, if cost matrix is:
matrix = [[5.1, 9.6, 1.7],
[10.2, 3.5, 2.8],
[8.3, 7.4, 4.9]]
Then output is as follows:
Lowest cost through this matrix:
[ 5, 9, 1]
[ 10, 3, 2]
[ 8, 7, 4]
(0, 0) -> 5.1
(1, 1) -> 3.5
(2, 2) -> 4.9
total cost: 13.5
We can see printed cost matrix isn't same as original cost matrix. And
it's not always the case, cost matrix would have all values in integral
form, cost of the assignment could be a float value.
Resolves: bmc#34
Add some examples of cost matrix with float values and their corresponding total cost of assignment, in main.
To compare two float values, "assert_almost_equal"[1] method has been used. If "places" argument isn't set, its value will be "7" (default). [1]: https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertAlmostEqual
|
Merged, with conflicts resolved.. Publishing shortly. Sorry for the delay. |
|
Pushed to PyPI in version 1.1.4. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 5, 2022
Version 1.1.4 (September, 2020) - Switched from Nose to Pytest for testing. Patch courtesy @kmosiejczuk, [PR #32](bmc/munkres#32), with some additional cleanup by me. - Fix to [Issue #34](bmc/munkres#34), in which `print_matrix` wasn't handling non-integral values. Patch courtesy @finn0, via [PR #35](bmc/munkres#35). - Various changes from `http:` URLs to `https:` URLs, courtesy @finn0 via [PR #36](bmc/munkres#36). Version 1.1.3: **Nonexistent**. Accidentally published before check-in. Deleted from PyPI. Use version 1.1.4. Version 1.1.2 (February, 2019) - Removed `NoReturn` type annotations, to allow compatibility with Python 3.5 releases prior to 3.5.4. Thanks to @jackwilsdon for catching that issue. Version 1.1.1 (February, 2019) - Version bump to get past a PyPI publishing issue. (Can't republish partially published 1.1.0.) Version 1.1.0 (February, 2019) - Only supports Python 3.5 or better, from this version forward (since Python 2 is at end of life in 11 months). - Added `typing` type hints. - Updated docs to use `pdoc`, since `epydoc` is pretty much dead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bmc can you take a look into this PR?
Closes: #34