Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS FIX] - Update meta tags for socials image display #2182

Merged
merged 20 commits into from
Apr 30, 2024

Conversation

Adamj1232
Copy link
Member

Description

Move image to a spot where it is available through an absolute path, add robot.txt, update meta tags

…velop

t merge develop# Please enter a commit message to explain why this merge is necessary,
@Adamj1232 Adamj1232 requested a review from leightkt April 30, 2024 16:07
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@algolia/client-search@4.17.0 None +5 258 kB shortcuts
npm/@babel/code-frame@7.23.5 None 0 23.3 kB nicolo-ribaudo
npm/@babel/compat-data@7.23.5 None 0 64.6 kB nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.23.6 None 0 52 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.23.4 None 0 31.6 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.23.5 None 0 11.7 kB nicolo-ribaudo
npm/@babel/highlight@7.23.4 None 0 18.4 kB nicolo-ribaudo
npm/@babel/parser@7.23.6 None 0 1.89 MB nicolo-ribaudo
npm/@babel/runtime@7.23.2 None 0 247 kB nicolo-ribaudo
npm/@babel/types@7.23.6 environment 0 2.41 MB nicolo-ribaudo
npm/@cosmjs/amino@0.29.5 None +1 227 kB webmaster128
npm/@cosmjs/crypto@0.29.4 None 0 139 kB webmaster128
npm/@cosmjs/encoding@0.29.5 None 0 24.6 kB webmaster128
npm/@cosmjs/math@0.29.5 None 0 36.8 kB webmaster128
npm/@cosmjs/proto-signing@0.29.5 None 0 80 kB webmaster128
npm/@cosmjs/stream@0.29.5 None 0 30.4 kB webmaster128
npm/@cosmjs/tendermint-rpc@0.29.5 network Transitive: environment +3 744 kB webmaster128
npm/@cosmjs/utils@0.29.5 None 0 14.5 kB webmaster128
npm/@docsearch/css@3.3.4 None 0 27.9 kB shortcuts
npm/@docsearch/js@3.3.4 Transitive: environment +4 2.12 MB shortcuts
npm/@emotion/serialize@1.1.4 environment +4 98.5 kB emotion-release-bot
npm/@ethereumjs/common@2.6.5 None 0 2.53 MB holgerd77
npm/@ethereumjs/tx@3.5.2 None 0 431 kB holgerd77
npm/@ethereumjs/util@8.1.0 None +6 2.59 MB holgerd77
npm/@iconify-json/ri@1.1.8 None 0 859 kB cyberalien
npm/@iconify/types@2.0.0 None 0 25.7 kB cyberalien
npm/@jridgewell/trace-mapping@0.3.18 None +2 259 kB jridgewell
npm/@lit/reactive-element@1.6.1 None 0 785 kB lit-robot
npm/@metamask/eth-sig-util@5.1.0 None 0 150 kB metamaskbot
npm/@ngraveio/bc-ur@1.1.6 None +1 138 kB antwnic4
npm/@noble/curves@1.2.0 None 0 1.35 MB paulmillr
npm/@noble/hashes@1.3.2 None 0 747 kB paulmillr
npm/@protobufjs/aspromise@1.1.2 None 0 9.05 kB dcode
npm/@safe-global/safe-apps-provider@0.18.0 None 0 33 kB dasanra
npm/@safe-global/safe-apps-sdk@8.1.0 None +1 242 kB dasanra
npm/@scure/base@1.1.6 None 0 80.4 kB paulmillr
npm/@shapeshiftoss/hdwallet-core@1.49.0 None +3 11.6 MB shapeshift-ci-bot
npm/@solana/web3.js@1.87.1 environment, eval, network +1 11.4 MB buffalojoec
npm/@sveltejs/adapter-static@2.0.2 environment 0 8.21 kB svelte-admin
npm/@sveltejs/kit@1.27.2 environment, eval +2 810 kB svelte-admin
npm/@svelteness/kit-docs@1.1.5 Transitive: filesystem, network +2 17 MB mihar-22
npm/@tailwindcss/typography@0.5.9 None 0 86.7 kB bradlc
npm/@toruslabs/base-controllers@2.9.0 network +3 9.29 MB chaitanyapotti
npm/@toruslabs/eccrypto@2.2.1 None 0 47.9 kB chaitanyapotti
npm/@toruslabs/openlogin-jrpc@4.7.2 Transitive: environment +6 2.39 MB chaitanyapotti

🚮 Removed packages: npm/@babel/core@7.23.2, npm/@babel/parser@7.23.0, npm/@babel/plugin-syntax-jsx@7.22.5, npm/@babel/types@7.23.0, npm/@unstoppabledomains/resolution@8.5.0, npm/@web3-onboard/react@2.8.11, npm/d@1.0.1, npm/es5-ext@0.10.62, npm/es6-symbol@3.1.3, npm/eslint-config-next@12.2.5, npm/eslint@8.22.0, npm/is-core-module@2.10.0, npm/jsx-ast-utils@3.3.3, npm/next-tick@1.1.0, npm/next@12.2.5, npm/object.assign@4.1.3

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/keccak@1.4.0
  • Install script: install
  • Source: npm run rebuild || echo "Keccak bindings compilation fail. Pure JS implementation will be used."
  • orphan: npm/keccak@1.4.0
Install scripts npm/@sveltejs/kit@1.27.2
  • Install script: postinstall
  • Source: node postinstall.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/keccak@1.4.0
  • @SocketSecurity ignore npm/@sveltejs/kit@1.27.2

@Adamj1232 Adamj1232 merged commit 0184045 into develop Apr 30, 2024
2 of 3 checks passed
@Adamj1232 Adamj1232 deleted the doc_fix/meta_tags_for_socials branch April 30, 2024 16:16
Adamj1232 added a commit that referenced this pull request Apr 30, 2024
* [DOCS FIX] - Update meta tags for socials image display (#2182)

* Move image to a spot where it is available through an absolute path, add robot.txt, update meta tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants