-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WalletConnect eth_RequestAccounts
flow along with update WC deps and add new optional params
#1622
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leightkt Judging from Infinity wallets github commit history I would be surprised if they have WC v2 support integrated |
@leightkt for a more complete list of larger wallets that do and dont support walletconnect v2 checkout - https://medium.com/walletconnect/weve-reset-the-clock-on-the-walletconnect-v1-0-shutdown-now-scheduled-for-june-28-2023-ead2d953b595 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to successfully connect wallet from https://react-web3wallet.vercel.app/walletconnect to demo
* Yarn docs * update favicon on docs site (#1611) * Update Notify section on the docs site and within readme (#1612) * Update notify docs on docs site and within readme * Update notify api docs * Add screenshots * Update signup link * Remove export from types in docs * Update Docs Favicon to Url (#1618) * Fix broken link in docs (#1616) * Add Kat to GH issue and notion card generation + Fix doc prop name for connect property (#1593) * Yarn the docs * Fix doc prop name for connect property * Add new notion Flag * Add Kat to gh issue notion cards * Update Broken Links on Docs Pages (#1619) * Update WalletConnect `eth_RequestAccounts` flow along with update WC deps and add new optional params (#1622) * Update WC packages * Add logs for testing * Refactor eth_requestAccounts flow * Why Don't I See My Wallet Link (#1617) * Add peer dep required to run package outside of walletconnect eco (#1623) * Update versions for release * Bump versions --------- Co-authored-by: Kat Leight <33187102+leightkt@users.noreply.github.com>
Description
Update WalletConnect
eth_RequestAccounts
flow as there was an issue with creating theconnect
listener after theconnect()
method was calledUpdate WC deps:
Add new optional params
qrModalOptions?: Web3ModalConfig
exposed with the new WC dep:Fixes #1608
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errors