Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate tensorrt models by default #14865

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Don't generate tensorrt models by default #14865

merged 1 commit into from
Nov 8, 2024

Conversation

NickM-27
Copy link
Collaborator

@NickM-27 NickM-27 commented Nov 8, 2024

Many users will be using the tensorrt image without using it for trt object detection. The model being created by default creates confusion and is unnecessary.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 7ed2ddf
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/672e0cd212e4b60008980a87
😎 Deploy Preview https://deploy-preview-14865--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hawkeye217 hawkeye217 merged commit 46ed520 into dev Nov 8, 2024
13 checks passed
@hawkeye217 hawkeye217 deleted the no-trt-default branch November 8, 2024 13:37
@kirsch33
Copy link
Contributor

i had to add YOLO_MODELS=${YOLO_MODELS:-""} to the run file within s6-overlay to get my tensorrt build to run after this, FYI. I can submit in a PR but wasnt sure if my fix was the best solution.

@NickM-27
Copy link
Collaborator Author

Sure that seems fine, I wasn't 100% sure because testing locally wasn't working either way for me and I didn't have time to run it on my prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants