Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #724

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Bug fix #724

merged 4 commits into from
Aug 24, 2024

Conversation

reubenharry
Copy link
Contributor

This PR puts right a few small (but important) bugs in the adaptation algorithm for unadjusted MCLMC. There was a division by 0 error, and a failure to catch NaNs in a certain part of the code.

@reubenharry reubenharry marked this pull request as ready for review August 22, 2024 17:29
@reubenharry reubenharry requested a review from junpenglao August 23, 2024 20:20
blackjax/adaptation/mclmc_adaptation.py Outdated Show resolved Hide resolved
blackjax/util.py Show resolved Hide resolved
@reubenharry reubenharry merged commit 072cc81 into blackjax-devs:main Aug 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants