-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor clean up for SMC #611
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 99.18% 99.18% -0.01%
==========================================
Files 57 57
Lines 2577 2576 -1
==========================================
- Hits 2556 2555 -1
Misses 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The sphinx doc raises for SMC btw, this is due to the discussion on the structure of the particles: there seem to be blank lines missing for the list and block. I was planning on having a look but if you are at it, maybe worth doing the change at the same time as this. |
Where is it btw? https://blackjax-devs.github.io/blackjax/autoapi/blackjax/smc/base/index.html looks fine? |
This only appears in the stdout when you run the doc.
…On Thu, 7 Dec 2023, 11:05 Junpeng Lao, ***@***.***> wrote:
The sphinx doc raises for SMC btw, this is due to the discussion on the
structure of the particles: there seem to be blank lines missing for the
list and block. I was planning on having a look but if you are at it, maybe
worth doing the change at the same time as this.
Where is it btw?
https://blackjax-devs.github.io/blackjax/autoapi/blackjax/smc/base/index.html
looks fine?
—
Reply to this email directly, view it on GitHub
<#611 (comment)>,
or unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AEYGFZ5AYCXGZACEM5XLG2LYIGIG5AVCNFSM6AAAAABAKYBN6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGA2DMNBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I will fix the sphinx error in another PR. |
* Minor clean up for SMC * Formatting
cc @AdrienCorenflos @ciguaran