Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean up for SMC #611

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Minor clean up for SMC #611

merged 2 commits into from
Dec 7, 2023

Conversation

junpenglao
Copy link
Member

@junpenglao junpenglao commented Dec 7, 2023

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (435bffd) 99.18% compared to head (797c1d3) 99.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   99.18%   99.18%   -0.01%     
==========================================
  Files          57       57              
  Lines        2577     2576       -1     
==========================================
- Hits         2556     2555       -1     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AdrienCorenflos AdrienCorenflos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrienCorenflos
Copy link
Contributor

The sphinx doc raises for SMC btw, this is due to the discussion on the structure of the particles: there seem to be blank lines missing for the list and block. I was planning on having a look but if you are at it, maybe worth doing the change at the same time as this.

@junpenglao
Copy link
Member Author

The sphinx doc raises for SMC btw, this is due to the discussion on the structure of the particles: there seem to be blank lines missing for the list and block. I was planning on having a look but if you are at it, maybe worth doing the change at the same time as this.

Where is it btw? https://blackjax-devs.github.io/blackjax/autoapi/blackjax/smc/base/index.html looks fine?

@AdrienCorenflos
Copy link
Contributor

AdrienCorenflos commented Dec 7, 2023 via email

@junpenglao
Copy link
Member Author

@junpenglao
Copy link
Member Author

I will fix the sphinx error in another PR.

@junpenglao junpenglao merged commit 73a6c0c into blackjax-devs:main Dec 7, 2023
7 checks passed
@junpenglao junpenglao deleted the smc branch December 7, 2023 17:20
junpenglao added a commit that referenced this pull request Mar 12, 2024
* Minor clean up for SMC

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants