Update the Metropolis-within-Gibbs example #558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Metropolis-within-Gibbs example markdown notebook to be compatible with API changes, as mentioned in #551.
Included a function that takes the variance of a normal distribution as a parameter and returns a RMH kernel with a normal proposal generator. Also added minor changes to text to keep consistency with updates. I have a couple more thoughts for a few more minor edits, so I'm opening this up a draft PR (also I'm a first time contributor).
potential (nitpicky) edits:
AlgorithmState
is mentioned, but is this an actual object in the code base referring to some generic class or type? If not, I think it would be better to refer to a generic state as "algorithm state", so its not confused as something in blackjax.blackjax.mcmc.algorithm.init()
to justinit()
, as the former makes it seem like there is an algorithm submodule.Also, make test reports that 3 tests are failing related to
tests/optimizers/test_pathfinder.py
. But I don't think it's related to my changes.Thank you for opening a PR!
A few important guidelines and requirements before we can merge your PR:
main
commit;pre-commit
is installed and configured on your machine, and you ran it before opening the PR;Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.