Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Added ability to enable metrics manager after it was disabled #451

Merged

Conversation

bmourat
Copy link
Contributor

@bmourat bmourat commented Aug 18, 2017

No description provided.

@msftclas
Copy link

@bmourat,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

if (disabled) {
[self unregisterObservers];
} else {
[self registerObservers];
[self startManager];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to generate a new session UUID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might even not have a session id, if startManager was not called, and since we a starting new session each time app is in background mode for 20 seconds or more, i don't think we need to worry about starting new session here. Besides it is rather logical to start new session each time after enabling metrics manager.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it makes sense to start a new session in case the feature was disabled and then enabled again.

@ElektrojungeAtWork ElektrojungeAtWork merged commit 3cb50f2 into bitstadium:develop Sep 1, 2017
@bmourat bmourat deleted the enable-metrics-in-runtime branch September 6, 2017 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants